Page MenuHomeFreeBSD
Differential D47854

hwreset: fix clk_id type
AcceptedPublic
Actions

Authored by br on Nov 30 2024, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 12:24 AM
Unknown Object (File)
Mon, Jan 6, 11:55 AM
Unknown Object (File)
Mon, Jan 6, 8:56 AM
Unknown Object (File)
Mon, Jan 6, 3:05 AM
Unknown Object (File)
Dec 13 2024, 12:34 PM
Unknown Object (File)
Dec 12 2024, 1:05 PM
Unknown Object (File)
Dec 11 2024, 8:18 AM
Unknown Object (File)
Dec 3 2024, 4:51 AM
View All 9 Files
Subscribers
None

Details

Reviewers
mhorne
jrtc27
Summary

The ID is passed as intptr_t everywhere except this place.
This is needed for Premier P550 that features 2 reset cells (unusually)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Nov 30 2024, 8:49 PM
br created this revision.
br added a child revision: D47853: eswin reset driver.
jrtc27 added a comment.Nov 30 2024, 8:57 PM

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

mhorne accepted this revision.Dec 2 2024, 5:09 PM
In D47854#1090987, @jrtc27 wrote:

Honestly we should instead be removing the use of intptr_t for hwreset, it's not a sensible type to use for an ID.

I agree, it should be converted to a long.

This commit is still correct as-is.

This revision is now accepted and ready to land.Dec 2 2024, 5:09 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
hwreset/
2 lines

Diff 147247

View Options

sys/dev/hwreset/hwreset.c

Loading...