Page MenuHomeFreeBSD
Differential D47738

tests: Demonstrate a bug in ppoll() and pselect().
ClosedPublic
Actions

Authored by des on Nov 25 2024, 5:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 3:21 PM
Unknown Object (File)
Sat, Jan 11, 9:45 AM
Unknown Object (File)
Thu, Jan 9, 6:13 PM
Unknown Object (File)
Mon, Jan 6, 2:47 AM
Unknown Object (File)
Mon, Jan 6, 12:36 AM
Unknown Object (File)
Sun, Jan 5, 8:43 PM
Unknown Object (File)
Sun, Jan 5, 9:40 AM
Unknown Object (File)
Sun, Jan 5, 8:53 AM
View All 23 Files
Subscribers
imp
kevans
markj

Details

Reviewers
markj
Group Reviewers
Klara
Commits
rG6748d4e0eb8a: tests: Add regression test for ppoll() / pselect() race.
Summary

This test demonstrates that ppoll() and pselect() can return 0 after a
signal was caught. This happens when the signal occurs after the
timeout has been reached but before the signal mask is restored on
return to user space.

Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Nov 25 2024, 5:16 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2024, 5:16 PM
des requested review of this revision.Nov 25 2024, 5:16 PM
Harbormaster completed remote builds in B60761: Diff 146914.Nov 25 2024, 5:16 PM
kevans added a subscriber: kevans.Nov 25 2024, 7:05 PM

I posted a candidate fix in D47741

des added a comment.Nov 25 2024, 7:18 PM

Sorry, I appear to have oversimplified the test case, I will amend it shortly

des updated this revision to Diff 146925.Nov 25 2024, 7:36 PM

Unsimplify

Harbormaster completed remote builds in B60765: Diff 146925.Nov 25 2024, 7:36 PM
des updated this revision to Diff 146929.Nov 25 2024, 7:38 PM

Further unsimplify

Harbormaster completed remote builds in B60766: Diff 146929.Nov 25 2024, 7:39 PM
des mentioned this in D47741: kern: restore signal mask before ast() for pselect/ppoll.Nov 25 2024, 7:44 PM
markj accepted this revision as: markj.Nov 25 2024, 8:15 PM
markj added a subscriber: markj.
markj added inline comments.
tests/sys/kern/prace.c
97

Extra newline.

104

I think some comment explaining what these tests are exercising would be useful.

This revision is now accepted and ready to land.Nov 25 2024, 8:15 PM
kevans mentioned this in rGccb973da1f1b: kern: restore signal mask before ast() for pselect/ppoll.Nov 26 2024, 4:05 AM
Closed by commit rG6748d4e0eb8a: tests: Add regression test for ppoll() / pselect() race. (authored by des). · Explain WhyNov 26 2024, 8:37 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG6748d4e0eb8a: tests: Add regression test for ppoll() / pselect() race..
des marked 2 inline comments as done.Nov 26 2024, 8:38 PM
kevans mentioned this in rGc4290f346662: kern: restore signal mask before ast() for pselect/ppoll.Dec 10 2024, 8:03 PM
kevans mentioned this in rGe5e44726d5af: kern: restore signal mask before ast() for pselect/ppoll.
des mentioned this in D27871: Rework jobc handling..Fri, Jan 3, 7:26 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
1 line
144 lines

Diff 147009

View Options

tests/sys/kern/Makefile

Loading...
View Options

tests/sys/kern/prace.c

Loading...