pf: fix potential state key leak
ClosedPublic
Actions

Authored by kp on Sat, Nov 9, 10:57 AM.

Tags

None

Referenced Files

	F102514663: D47495.diff
	Wed, Nov 13, 10:34 AM

	Unknown Object (File)
	Mon, Nov 11, 12:27 PM

	Unknown Object (File)
	Mon, Nov 11, 11:43 AM

	Unknown Object (File)
	Mon, Nov 11, 11:33 AM

	Unknown Object (File)
	Sun, Nov 10, 3:18 AM

	Unknown Object (File)
	Sun, Nov 10, 12:22 AM

	Unknown Object (File)
	Sun, Nov 10, 12:17 AM

	Unknown Object (File)
	Sun, Nov 10, 12:15 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG371bd29d4b22: pf: fix potential state key leak

Summary

If we fail to attach the new state keys in pf_state_key_attach() we are
expected to free both keys. Do so.
Note that in some scenarios both key are the same, so check for that
before freeing.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sat, Nov 9, 10:57 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSat, Nov 9, 10:57 AM

kp requested review of this revision.Sat, Nov 9, 10:57 AM

Harbormaster completed remote builds in B60455: Diff 146195.Sat, Nov 9, 10:57 AM

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Nov 13, 10:34 AM

Closed by commit rG371bd29d4b22: pf: fix potential state key leak (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG371bd29d4b22: pf: fix potential state key leak.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

4 lines

Diff 146346

View Options

pf: fix potential state key leakClosedPublicActions