Page MenuHomeFreeBSD
Differential D47464

lib/libcrypt: remove ldscript hack
AbandonedPublic
Actions

Authored by fuz on Nov 5 2024, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 2:54 AM
Unknown Object (File)
Thu, Dec 5, 5:51 AM
Unknown Object (File)
Nov 21 2024, 4:29 AM
Unknown Object (File)
Nov 16 2024, 10:55 AM
Unknown Object (File)
Nov 16 2024, 6:59 AM
Unknown Object (File)
Nov 15 2024, 9:39 PM
Unknown Object (File)
Nov 13 2024, 1:20 PM
Unknown Object (File)
Nov 13 2024, 12:25 AM
View All 16 Files
Subscribers
bdrewery
emaste

Details

Reviewers
kevans
imp
bapt
Summary

This hack caused the bootstrap build to fail on macOS as macOS ld(1) does
not support static libraries being linker scripts. As a consequence, static
consumers of libcrypt now need to link with -lcrypt -lmd instead of just
-lmd.

Relnotes: yes
Fixes: cb5e41b160838880de7d03100afa02e4edee5a9e (D47062)

Test Plan

build test successful, CI tests no longer fail.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60417
Build 57301: arc lint + arc unit

Event Timeline

fuz requested review of this revision.Nov 5 2024, 10:54 PM
fuz created this revision.
Harbormaster completed remote builds in B60417: Diff 146086.Nov 5 2024, 10:54 PM
fuz mentioned this in D47465: src.libnames.mk: add the notion of hacked a files.Nov 6 2024, 9:36 AM

Alternatively, D47465 fixes the ldscript hack to cross-build on macOS.

fuz abandoned this revision.Nov 6 2024, 2:32 PM

@bapt has managed to fix the issue causing the bootstrap to fail on macOS. Seems like we don't need to break compatibility after all.

Revision Contents
Changeset List

Diff 146086

View Options

ObsoleteFiles.inc

Loading...
View Options

lib/libcrypt/Makefile

Loading...
View Options

lib/libcrypt/crypt.3

Loading...
View Options

lib/libcrypt/libcrypt.aldscript

Loading...
View Options

lib/libcrypt/libcrypt.ldscript

Loading...