linux sendfile: Fix handling of non-blocking sockets
Needs ReviewPublic
Actions

Authored by markj on Tue, Nov 5, 1:59 AM.

Details

Reviewers

glebius
dchagin

Summary

FreeBSD sendfile() may perform a partial transfer and return EAGAIN if
the socket is non-blocking. Linux sendfile expects no error in this
case, so squash EAGAIN.

PR: 282495

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60391
Build 57275: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Nov 5, 1:59 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Nov 5, 1:59 AM

markj requested review of this revision.Tue, Nov 5, 1:59 AM

Harbormaster completed remote builds in B60391: Diff 146031.Tue, Nov 5, 1:59 AM

markj added inline comments.Tue, Nov 5, 2:02 AM

sys/compat/linux/linux_socket.c
2596	This comes from commit 4f9fac78d4da6, but I don't really understand it: what exactly is triggering ENOBUFS?

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_socket.c

7 lines

Diff 146031

View Options

sys/compat/linux/linux_socket.c

linux sendfile: Fix handling of non-blocking socketsNeeds ReviewPublicActions