Differential D47357

cd9660: Apply the file and directory mode masks bits to all 12 access bits
AcceptedPublic
Actions

Authored by jhb on Thu, Oct 31, 3:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 1:44 PM

	Unknown Object (File)
	Tue, Nov 5, 3:42 AM

	Unknown Object (File)
	Sun, Nov 3, 9:14 PM

Subscribers

Details

Reviewers

stevek
sjg
olce

Summary

This permits the mask bits to control the upper 3 bits used for setuid,
setgid, and sticky permissions. While here, clarify the manpage language
as non-Rockridge volumes with extended attributes can also supply users
and groups along with permissions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60328
Build 57212: arc lint + arc unit

Event Timeline

jhb created this revision.Thu, Oct 31, 3:51 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Oct 31, 3:51 PM

jhb requested review of this revision.Thu, Oct 31, 3:51 PM

Harbormaster completed remote builds in B60281: Diff 145739.Thu, Oct 31, 3:51 PM

jhb mentioned this in D46948: cd9660: Preserve non-access permission bits in file modes.Thu, Oct 31, 3:52 PM

Thanks, and also for amending the doc with more technical details.

This revision is now accepted and ready to land.Thu, Oct 31, 4:56 PM

sjg added inline comments.Thu, Oct 31, 8:49 PM

sbin/mount_cd9660/mount_cd9660.8
91	644 is read and write for owner - no execute

jhb added inline comments.Fri, Nov 1, 1:56 PM

sbin/mount_cd9660/mount_cd9660.8
91	sigh, my bad.

jhb marked an inline comment as done.Fri, Nov 1, 1:57 PM

jhb added inline comments.

sbin/mount_cd9660/mount_cd9660.8
100	This should also be 555

Correct some permissions constants

This revision now requires review to proceed.Fri, Nov 1, 1:58 PM

Harbormaster completed remote builds in B60328: Diff 145834.Fri, Nov 1, 1:58 PM

Sigh, had missed that too. Thanks.

This revision is now accepted and ready to land.Fri, Nov 1, 2:05 PM

@stevek does this version work ok for you?

Revision Contents
Changeset List

Path

Size

sbin/

mount_cd9660/

23 lines

sys/

fs/

cd9660/

cd9660_vfsops.c

2 lines

Diff 145834

sbin/mount_cd9660/mount_cd9660.8

Loading...

sys/fs/cd9660/cd9660_vfsops.c

Loading...