mixer: Fix a bogus free() call in the main loop
ClosedPublic
Actions

Authored by markj on Wed, Oct 23, 4:15 PM.

Tags

None

Referenced Files

	F102040562: D47266.id145405.diff
	Wed, Nov 6, 8:59 PM

	Unknown Object (File)
	Fri, Nov 1, 1:58 PM

	Unknown Object (File)
	Fri, Nov 1, 1:58 PM

	Unknown Object (File)
	Fri, Nov 1, 1:58 PM

	Unknown Object (File)
	Fri, Nov 1, 1:49 PM

	Unknown Object (File)
	Thu, Oct 31, 5:40 PM

	Unknown Object (File)
	Thu, Oct 31, 1:17 PM

	Unknown Object (File)
	Sat, Oct 26, 10:06 PM

View All 13 Files

Subscribers

imp

Details

Reviewers

christos

Commits

rGbf2145f361b8: mixer: Fix a bogus free() call in the main loop
rGc22be0b181e9: mixer: Fix a bogus free() call in the main loop

Summary

After a strsep() call, p might not point at the original allocation
anymore.

Reported by: CHERI

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Wed, Oct 23, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Oct 23, 4:15 PM

markj requested review of this revision.Wed, Oct 23, 4:15 PM

Harbormaster completed remote builds in B60172: Diff 145391.Wed, Oct 23, 4:15 PM

Good catch, thanks!

This revision is now accepted and ready to land.Wed, Oct 23, 4:30 PM

Closed by commit rGc22be0b181e9: mixer: Fix a bogus free() call in the main loop (authored by markj). · Explain WhyWed, Oct 23, 10:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc22be0b181e9: mixer: Fix a bogus free() call in the main loop.

markj added a commit: rGbf2145f361b8: mixer: Fix a bogus free() call in the main loop.Wed, Oct 30, 1:22 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

mixer.c

6 lines

Diff 145405

View Options

mixer: Fix a bogus free() call in the main loopClosedPublicActions