Page MenuHomeFreeBSD
Differential D47059

articles/committers-guide: Document "Discussed with"
ClosedPublic
Actions

Authored by 0mp on Oct 11 2024, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 1:19 PM
Unknown Object (File)
Fri, Jan 10, 5:33 AM
Unknown Object (File)
Tue, Jan 7, 12:23 PM
Unknown Object (File)
Mon, Jan 6, 6:57 PM
Unknown Object (File)
Mon, Jan 6, 5:13 PM
Unknown Object (File)
Mon, Jan 6, 12:06 PM
Unknown Object (File)
Mon, Jan 6, 11:48 AM
Unknown Object (File)
Mon, Jan 6, 9:40 AM
View All 20 Files
Subscribers
None

Details

Reviewers
markj
imp
Commits
R9:65b45fee8ce3: articles/committers-guide: Document "Discussed with"
Summary

Reported by: markj

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested review of this revision.Oct 11 2024, 2:10 PM
0mp created this revision.
Harbormaster completed remote builds in B59905: Diff 144634.Oct 11 2024, 2:10 PM
0mp added reviewers: markj, imp.Oct 11 2024, 2:10 PM

I've added you, @imp, to the reviewers of this change as you usually have smart things to say about things related to the culture of the project ;) I hope you don't mind.

imp accepted this revision.Oct 11 2024, 2:13 PM
This revision is now accepted and ready to land.Oct 11 2024, 2:13 PM
markj added inline comments.Oct 11 2024, 2:25 PM
documentation/content/en/articles/committers-guide/_index.adoc
2584

Grammar/style nits.

0mp updated this revision to Diff 144646.Oct 11 2024, 3:35 PM

Incorporate Mark's feedback

This revision now requires review to proceed.Oct 11 2024, 3:35 PM
Harbormaster completed remote builds in B59908: Diff 144646.Oct 11 2024, 3:35 PM
0mp marked an inline comment as done.Oct 11 2024, 3:36 PM
markj accepted this revision.Oct 11 2024, 3:48 PM

Thanks for documenting this.

This revision is now accepted and ready to land.Oct 11 2024, 3:48 PM
0mp added a comment.Oct 11 2024, 4:05 PM

Thanks!

Closed by commit R9:65b45fee8ce3: articles/committers-guide: Document "Discussed with" (authored by 0mp). · Explain WhyOct 11 2024, 4:05 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: R9:65b45fee8ce3: articles/committers-guide: Document "Discussed with".

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
articles/
committers-guide/
4 lines

Diff 144654

View Options

documentation/content/en/articles/committers-guide/_index.adoc

Loading...