tcp: improve MAC error handling for SYN segments
Needs ReviewPublic
Actions

Authored by tuexen on Mon, Sep 23, 8:46 PM.

Details

Reviewers

markj
glebius
rrs
rscheff
peter.lei_ieee.org
lstewart

Group Reviewers

transport

Summary

Don't leak a maclabel when SYN segments are processed which results in an error due to MD5 signature handling.
Tweak the #idef MAC to allow additional upcoming changes.
This patch depends on D46701 to avoid double frees.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Mon, Sep 23, 8:46 PM

Herald added a reviewer: transport. · View Herald TranscriptMon, Sep 23, 8:46 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Mon, Sep 23, 8:46 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

3 lines

Diff 143652

View Options

sys/netinet/tcp_syncache.c

tcp: improve MAC error handling for SYN segmentsNeeds ReviewPublicActions