Differential D46708

ixgbe: fix compilation for VF
ClosedPublic
Actions

Authored by dougm on Fri, Sep 20, 6:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 26, 7:08 AM

	Unknown Object (File)
	Wed, Sep 25, 7:53 PM

	Unknown Object (File)
	Sun, Sep 22, 7:22 PM

	Unknown Object (File)
	Fri, Sep 20, 2:43 PM

	Unknown Object (File)
	Fri, Sep 20, 9:35 AM

	Unknown Object (File)
	Fri, Sep 20, 7:52 AM

Subscribers

Details

Reviewers

alc
kbowling

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rGed31e4eca057: ixgbe: fix compilation for VF
rGdcf7b92d48b6: ixgbe: fix compilation for VF
rG267f223f622f: ixgbe: fix compilation for VF

Summary

Adding the mailbox API to ixgbe has broken compilation. A comment in ixgbe_mbx.h says "VF: Only the very first (0) set should be used" right before an array of 64 ops is defined. However, in some vf-related code, "ops" is used without an array index and compilation fails. This change adds a [0] index to "ops" in enough places to allow compilation to complete.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Fri, Sep 20, 6:23 AM

Herald added a subscriber: ae. · View Herald TranscriptFri, Sep 20, 6:23 AM

dougm requested review of this revision.Fri, Sep 20, 6:23 AM

Thank you this is the right fix. I will commit it now with your authorship as I would otherwise commit the same thing now to fix the tree.

This revision is now accepted and ready to land.Fri, Sep 20, 7:54 AM

Closed by commit rG267f223f622f: ixgbe: fix compilation for VF (authored by dougm, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyFri, Sep 20, 7:58 AM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG267f223f622f: ixgbe: fix compilation for VF.

Owners added a reviewer: Restricted Owners Package.Fri, Sep 20, 7:58 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Sep 20, 7:58 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGdcf7b92d48b6: ixgbe: fix compilation for VF.Fri, Sep 27, 3:36 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGed31e4eca057: ixgbe: fix compilation for VF.Fri, Sep 27, 3:41 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

14 lines

Diff 143518

sys/dev/ixgbe/if_sriov.c

Loading...