Page MenuHomeFreeBSD

Adding QEMU Virtualization to Handbook
Needs ReviewPublic

Authored by jpb_jimby.name on Thu, Sep 12, 8:10 PM.
Tags
None
Referenced Files
F95815071: D46659.id143293.diff
Sun, Sep 22, 6:26 PM
F95815035: D46659.id143293.diff
Sun, Sep 22, 6:26 PM
F95656390: D46659.id143293.diff
Sun, Sep 22, 1:04 AM
F95656364: D46659.id143293.diff
Sun, Sep 22, 1:04 AM
Unknown Object (File)
Sat, Sep 21, 7:15 AM
Unknown Object (File)
Sat, Sep 21, 7:15 AM
Unknown Object (File)
Fri, Sep 20, 1:23 AM
Unknown Object (File)
Fri, Sep 20, 1:23 AM

Details

Reviewers
debdrup
Group Reviewers
docs
Summary

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59466
Build 56353: arc lint + arc unit

Event Timeline

jpb_jimby.name created this revision.
jpb_jimby.name edited the summary of this revision. (Show Details)

Fixed FreeBSD download link to use dvd1.

Nothing major. I may have missed some of those in my initial review. Nice doc overall.

documentation/content/en/books/handbook/virtualization/_index.adoc
520
525
562

I'd use the month itself instead, if known. (Not all our users are in the same hemisphere.)

567–568

Instead, I'd use % (not root) or # (root) shell prompts as done in the rest of the handbook and stated in https://docs.freebsd.org/en/books/handbook/preface/#preface-conv .

638–646
658

I'd like someone more familiar with QEMU and system administration than me to look at the use of sudo here. I'll just note that to me it sounds inconsistent with the suggestion to add a -runas option below.

698
704
744

Same remark here as for the sudo in left.sh above.

859

And again re sudo

949
1027
1083

If you keep the sudo in left.sh below, do you also need the one here?

1091

Same here re sudo in scripts.

1137
1217

Here too I'd use the month if known.

1276
jpb_jimby.name added inline comments.
documentation/content/en/books/handbook/virtualization/_index.adoc
658

I've removed all the "sudo" statements and replaced with the root prompt "#". The "-runas" option is designed to run the QEMU command but drop privileges before running the VM.

From QEMU(1):

-runas user
       Immediately before starting guest execution, drop root
       privileges, switching to the specified user.
698

edited as "... metadata during first use" instead of "metadata during the first use".

1083

I've changed out all "sudo" and replaced with the root prompt "#".

1091

Same as above. Also, in this example I removed the text
"# left VM script" since it could be misunderstood as a command run as root.

I did the same for the script listing at line 853.