Page MenuHomeFreeBSD

ena: Improve reset reason statistics
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 12:17 AM
Unknown Object (File)
Mon, Sep 23, 11:22 PM
Unknown Object (File)
Mon, Sep 23, 3:23 PM
Unknown Object (File)
Sun, Sep 22, 11:35 PM
Unknown Object (File)
Sun, Sep 22, 11:11 AM
Unknown Object (File)
Sat, Sep 21, 9:49 AM
Unknown Object (File)
Wed, Sep 18, 7:08 PM
Unknown Object (File)
Mon, Sep 16, 8:28 PM
Subscribers

Details

Reviewers
cperciva
Summary

The driver uses different reset reasons.
Some of them are counted and presented in the driver statistics.
There are cases where statistics are counted on a ring level,
but these are zeroed after a reset procedure takes place.

This commit makes the following changes:

  1. Add statistics for the unrepresented reset reasons.
  2. Add reset reasons which are counted on a ring level,

to be also global for better tracking.

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59087
Build 55974: arc lint + arc unit

Event Timeline

sys/dev/ena/ena.c
3017

I'm not clear on why this (and the similar increment of admin_q_pause) are going away.

sys/dev/ena/ena.c
3017

With this commit, these incrementations are being done in ena_trigger_reset() now
We send the reset reason there and increment the relevant statistic including admin_q_pause and wd_expired