Page MenuHomeFreeBSD
Differential D45506

LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC
ClosedPublic
Actions

Authored by bz on Jun 5 2024, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 5:19 PM
Unknown Object (File)
Tue, Nov 12, 10:24 AM
Unknown Object (File)
Tue, Nov 12, 10:21 AM
Unknown Object (File)
Tue, Nov 12, 10:20 AM
Unknown Object (File)
Wed, Oct 23, 4:44 PM
Unknown Object (File)
Wed, Oct 23, 4:44 PM
Unknown Object (File)
Wed, Oct 23, 4:44 PM
Unknown Object (File)
Wed, Oct 23, 4:35 PM
View All 48 Files
Subscribers
adrian
emaste
imp
linuxkpi

Details

Reviewers
adrian
Group Reviewers
wireless
Commits
rG88de7a318d13: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC
rGe0ac61759dea: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC
rG3e0915b7b685: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC
Summary

IEEE80211_HT_CAP_RX_STBC was set to 0x100 instead of 0x300.
Correct to get the expected behavior.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: b0f73768220e9 LinuxKPI: 802.11 header updates

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jun 5 2024, 10:04 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJun 5 2024, 10:04 PM
bz requested review of this revision.Jun 5 2024, 10:04 PM
Harbormaster completed remote builds in B58077: Diff 139538.Jun 5 2024, 10:04 PM
bz added inline comments.Jun 5 2024, 10:11 PM
sys/compat/linuxkpi/common/include/linux/ieee80211.h
270

There's a question here I cannot answer anymore; I believe the proper follow-up would be to actually define the to the net80211 values directly.
The only reason I can think of this doesn't work or not to do it is if there are naming conflicts or other header include collisions or "include-wars" to resolve between net80211 and linuxkpi.

adrian added a subscriber: adrian.Jun 5 2024, 11:05 PM

Yeah, I remember hitting namespace clashes when trying to do this with some earlier linux driver ports. :(

adrian accepted this revision as: adrian.Jun 5 2024, 11:05 PM
This revision is now accepted and ready to land.Jun 5 2024, 11:05 PM
Closed by commit rG3e0915b7b685: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC (authored by bz). · Explain WhyJun 7 2024, 9:17 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG3e0915b7b685: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC.
bz added a commit: rGe0ac61759dea: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC.Jun 12 2024, 4:42 PM
bz added a commit: rG88de7a318d13: LinuxKPI: 802.11: Fix definition of IEEE80211_HT_CAP_RX_STBC.Jun 12 2024, 7:17 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
2 lines

Diff 139638

View Options

sys/compat/linuxkpi/common/include/linux/ieee80211.h

Loading...