net/wifi-firmware-kmod: [WIP] Attempt to simplify wifi-firmware ports

[jrm]

Summary

This is very much still a work in progress. You may not want to spend time looking yet, but I'm creating this reviewing now to prevent any duplication of work. I may not have an opportunity to continue for some time due to BSDCan

[jrm]

TODO:

• look into the post-install-license target
• run through linters (portclippy/portfmt)
• testing

[bz]

I compared this to a pre-flavor version I had (which never was in Phab).
Flavors were an after-though for this revision after manu requested the firmware to be broken up in D44918.

I think I in the end indeed just substituted most of the WRCSRC bits with WRKSRC/FLAVOR and done the trick from porters handbook given one of the FLAVOR variables wasn't set for one of the .for loops at the right moment and weird stuff had happened. If this is not a problem anymore I'll be more than happy with your cleanup. Let me know when you are done and I'll run a build.

It'll likely make it easier to later add (a) per-__FreeBSD_version versions and (b) only install the firmware and no more .ko at all in main and later (given imp's work there).

[bz]

Thanks a lot for doing it and taking the time. It was last year and the this year hard for anything to step up despite that I had asked at some point on wireless (interested parties) and added ports committers as subscribers.

[bz]

net/wifi-firmware-kmod/Makefile.inc

30

I think I have an idea how to sort the licenses; I'll see if I can find time to fully test in between other things.

[jrm]

net/wifi-firmware-kmod/Makefile.inc

30

Hi Bjoern,

I believe there are two reasonable solutions.

1. Update Mk/bsd.license.mk to add something like a LICENSE_EXTRA variable to record these extra files associated with the main LICENSE_FILE. This way ports will only need to set one variable, and the license framework will handle everything in a /correct/ way.

2. Append all these files into one license file.

1. will make this and potentially other ports simpler, and 2. will be easier and quicker now.

What do you think?

[bz]

Hi Joe,

I took your changes from here and posted an attempt to sort out the license file problem a different way.
See https://reviews.freebsd.org/D46124

I don't know if that approach is feasible but we can also discuss that there.

[jrm]

This work was incorporated into Bjoern's 8f79c11c717126a42a6f17f30a193cf1da866831.