sound: Fix minchn, maxchn and fmts in sndstat_get_caps()
ClosedPublic
Actions

Authored by christos on May 22 2024, 11:19 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch
brooks

Commits

rG0aa767021c19: sound: Fix minchn, maxchn and fmts in sndstat_get_caps()
rG425a7bc465d4: sound: Fix minchn, maxchn and fmts in sndstat_get_caps()

Summary

The current implementation (incorrectly) passes the channel encoding
value to AFMT_CHANNEL(), which will always return 0, since the channel
number bits are masked out by AFMT_ENCODING().

Also add missing fmts initialization and aggregate encoding formats
into it directly.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.May 22 2024, 11:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 22 2024, 11:19 PM

christos requested review of this revision.May 22 2024, 11:19 PM

Harbormaster completed remote builds in B57859: Diff 138953.May 22 2024, 11:19 PM

dev_submerge.ch added inline comments.May 23 2024, 12:04 AM

sys/dev/sound/pcm/sndstat.c
354	We should aggregate the encoding formats into `*fmts` here, it will be left (and used) uninitialized otherwise. And yes, it wasn't initialized in the original code either, let's fix that.

christos retitled this revision from sound: Fix min and max channel counting in sndstat_get_caps() to sound: Fix minchn, maxchn and fmts in sndstat_get_caps().May 23 2024, 12:11 AM

christos edited the summary of this revision. (Show Details)