Page MenuHomeFreeBSD
Differential D45223

bhyve: avoid resource leak in error path
ClosedPublic
Actions

Authored by khorben_defora.org on May 16 2024, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 2:33 AM
Unknown Object (File)
Fri, Nov 8, 1:59 AM
Unknown Object (File)
Thu, Nov 7, 6:37 PM
Unknown Object (File)
Thu, Nov 7, 7:42 AM
Unknown Object (File)
Wed, Nov 6, 10:53 PM
Unknown Object (File)
Wed, Nov 6, 4:15 PM
Unknown Object (File)
Tue, Nov 5, 5:20 PM
Unknown Object (File)
Tue, Nov 5, 9:44 AM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
emaste
markj
corvink
jhb
Group Reviewers
bhyve
Commits
rG88069992b210: bhyve: avoid resource leak in error path
rGe9806d21282d: bhyve: avoid resource leak in error path
Summary

In e820_finalize(), the e820_fwcfg_item variable, containing the etc/e820 file (for the e820 table from the BIOS) is not free()'d when it could not be added to the QEMU firmware configuration device (fw_cfg).

Test Plan

Source code review.

The only user of this function I could find is bhyve_init_platform_late(), which is called by main() in bhyverun.c, which exits upon errors. (4 "exited due to an error")

Therefore, as things are this fix looks superfluous, but it would quiet Coverity down for this code path.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khorben_defora.org created this revision.May 16 2024, 5:25 PM
Herald added a reviewer: bhyve. · View Herald TranscriptMay 16 2024, 5:25 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
khorben_defora.org requested review of this revision.May 16 2024, 5:25 PM
khorben_defora.org edited the test plan for this revision. (Show Details)
jhb accepted this revision.May 16 2024, 5:35 PM
jhb added a reviewer: corvink.
This revision is now accepted and ready to land.May 16 2024, 5:35 PM
corvink accepted this revision.May 17 2024, 6:32 AM
Closed by commit rGe9806d21282d: bhyve: avoid resource leak in error path (authored by khorben_defora.org, committed by emaste). · Explain WhyMay 17 2024, 4:27 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGe9806d21282d: bhyve: avoid resource leak in error path.
emaste added inline comments.May 17 2024, 5:16 PM
usr.sbin/bhyve/amd64/e820.c
490

what happens with e820_fwcfg_item->data in this case?

jhb added inline comments.May 17 2024, 7:21 PM
usr.sbin/bhyve/amd64/e820.c
490

The ownership was handed off to qemu_fwcfg_add_file

emaste added a commit: rG88069992b210: bhyve: avoid resource leak in error path.Aug 1 2024, 5:36 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
amd64/
2 lines

Diff 138661

View Options

usr.sbin/bhyve/amd64/e820.c

Loading...