Page MenuHomeFreeBSD
Differential D45077

libdiff: Fix type issues.
ClosedPublic
Actions

Authored by des on Fri, May 3, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 11:57 PM
Unknown Object (File)
Tue, May 7, 11:57 PM
Unknown Object (File)
Tue, May 7, 11:57 PM
Unknown Object (File)
Tue, May 7, 11:57 PM
Unknown Object (File)
Tue, May 7, 8:02 PM
Unknown Object (File)
Sun, May 5, 10:12 PM
Unknown Object (File)
Sat, May 4, 4:09 AM
Unknown Object (File)
Sat, May 4, 3:37 AM
Subscribers
imp
markj

Details

Reviewers
allanjude
markj
Group Reviewers
Klara
Commits
rG0549218b43f0: libdiff: Fix type issues.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Fri, May 3, 11:54 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, May 3, 11:54 AM
des requested review of this revision.Fri, May 3, 11:54 AM
Harbormaster completed remote builds in B57566: Diff 138099.Fri, May 3, 11:54 AM
allanjude accepted this revision as: allanjude.Fri, May 3, 1:26 PM
This revision is now accepted and ready to land.Fri, May 3, 1:26 PM
markj added a subscriber: markj.Fri, May 3, 1:58 PM
markj added inline comments.
contrib/libdiff/lib/diff_main.c
177

Why does r have type ssize_t at all? It looks like it should be int, as that's what read_at() and buf_cmp() return.

des added inline comments.Fri, May 3, 2:53 PM
contrib/libdiff/lib/diff_main.c
177

good point, I'll change it

des updated this revision to Diff 138108.Fri, May 3, 2:55 PM

avoid unnecessary casts

This revision now requires review to proceed.Fri, May 3, 2:55 PM
Harbormaster completed remote builds in B57571: Diff 138108.Fri, May 3, 2:55 PM
des marked an inline comment as done.Fri, May 3, 2:55 PM
markj accepted this revision as: markj.Fri, May 3, 2:57 PM
This revision is now accepted and ready to land.Fri, May 3, 2:57 PM
Closed by commit rG0549218b43f0: libdiff: Fix type issues. (authored by des). · Explain WhyFri, May 3, 3:04 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG0549218b43f0: libdiff: Fix type issues..

Revision Contents
Changeset List

PathSize
contrib/
libdiff/
lib/
5 lines

Diff 138109

View Options

contrib/libdiff/lib/diff_main.c

Loading...