irc/kvirc: update to 5.2.4

[vvd]

Summary

News / Changelog:
https://www.kvirc.net/?id=news&story=2024.03.09.12.18.1.story&dir=latest
https://www.kvirc.net/?id=news&story=2024.05.11.13.48.1.story&dir=latest
https://github.com/kvirc/KVIrc/releases/tag/5.2.2
https://github.com/kvirc/KVIrc/releases/tag/5.2.4

Tested in poudriere and live system 13.3-p2 amd64 build and run.

[arrowd]

irc/kvirc/Makefile

5–11

While there, can you switch WWW to https?

67

What does that mean?

85

No need for +=

89

No need to list duplicated deps.

[vvd]

irc/kvirc/Makefile

5–11

Ok.

67

Not linked with libgsm.so, but uses dlopen(libgsm.so) - stage-qa write warning about libgsm.so isn't used.

85

Copy&paste typo. Will fix it.

89

Used several libs from one port - I left all.
OK: "There can be only one"™

[arrowd]

irc/kvirc/Makefile

67

Then it should be RUN_DEPENDS=${LOCALBASE}/lib/libgsm.so, I'd say.

[vvd]

irc/kvirc/Makefile

67

Really?! Didn't know. :-o

I have almost same for net/freerdp{,3}:

# LoadLibraryA("libpcsclite.so")
PCSC_LIB_DEPENDS=       libpcsclite.so:devel/pcsc-lite
PCSC_CMAKE_BOOL=        WITH_PCSC

Does this need to be fixed too?

[arrowd]

irc/kvirc/Makefile

67

With the upcoming "autodeps" switch by bapt - yes, this is the right thing to do.

[vvd]

irc/kvirc/Makefile

67

And audio/audacity with option FFMPEG.

[vvd]

Upstream committed to master branch all fixes based on our patches - use this commit instead of local patches.

[arrowd]

irc/kvirc/pkg-plist

3

The initial purpose of VER substitute is to prevent churn when doing updates. Adding a new substitution defeats its purpose. I'd leave %%VER%% as it is.

78

There are no other places where these substitutions are used, so I'm also against adding them.

[vvd]

irc/kvirc/pkg-plist

78

This substitutions help to update pkg-plist - don't forget to accidentally update the version when updating the port version. This is not such a rare mistake.
But if you, as a kde@, think otherwise, then I can only comply.

[vvd]

Create PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278718

[makc]

irc/kvirc/Makefile

5–11

I'd drop "free portable" from the COMMENT. Overwhelming majority of the ports are "free" software, hence free is kind of expected. "Portable" — who cares about portability when you install it from ports/packages?

irc/kvirc/pkg-plist

3

I agree with Gleb, renaming VER to MINOR subverts the same reason VER was introduced for.

78

There's no need for MAJOR, it won't change for a long time.
Given we already have VER I'd use FULL_VER, VERSION or PORTVERSION instead of PATCH. See Qt/KDE and other ports for example.

[vvd]

irc/kvirc/Makefile

5–11

Copy&paste from https://www.kvirc.net/:

KVIrc is a free portable IRC client based on the excellent Qt GUI toolkit.

irc/kvirc/pkg-plist

78

Returned VER, replaced PATCH with FULL_VER, removed MAJOR.

[vvd]

irc/kvirc/pkg-plist

846

This is 2nd place with FULL_VER.

[makc]

Vlad, there is no need in making option for everything. Instead, try to minimize list of options when creating ports. Group similar functionality under single option (or use RADIO/MULTI etc), don't make options for features that require light or common dependencies, especially if a feature does not need deps at all. Sometimes having too many options is worst than having no options.
And of course these are not 100% strict rules.

irc/kvirc/Makefile

40

Try to explain what DDC_VOICE/VIDEO means, e.g.
Direct client voice/video connection support

I'd also merged them into single option: is there a reason to have video "chat" without audio?

41

I'm surprised that ENCHANT is not in options.desc.mk yet.

42

This option does not need any dependency. I'd enabled corresponding cmake toggle by default and removed the option from the port.

Same for IPV6

43

KDE_DESC= KDE desktop environment support

It is not in options.desc.mk also! omg!

44

This description is quite generic and options.desc.mk is already provides it.

45

"Link preview via qtwebengine" or "Web browser plugin" depending on what this option enables.

50

qt5-dbus is already pulled by qt5-gui, thus this option really does not bring any new dependency. Again, I'd enabled dbus functionally by default and removed the option.

[vvd]

Small fixes in options.

[vvd]

irc/kvirc/Makefile

40

It's 2 different independent features via DCC protocol:
/dcc.video NICK and /dcc.voice NICK

41

I can add it if you help with correct description.
Do I need approval from maybe portmgr@?

42

GTKSTYLE:

By default we disable QGtkStyle since it messes up with our theming
Some users want it anyway, and we sometimes need to check it

IPV6 option removed and added WANT_IPV6 to CMAKE_ON.

43

Same as for ENCHANT.

44

I don't know how to describe it better:
https://github.com/kvirc/KVIrc/blob/5.2.2/CMakeLists.txt#L550

45

Description for WEBENGINE replaced with text from upstream:
https://github.com/kvirc/KVIrc/blob/5.2.2/CMakeLists.txt#L434
Don't know what it really do.

Old description for QTWEBKIT was: Use obsolete qt5-webkit to build Browser Plugin.
WEBENGINE replaced QTWEBKIT.

50

It linked with qt-dbus only if WANT_QTDBUS=true or WANT_KDE=true.
In other cases it doesn't linked with qt-dbus.

[vvd]

• Use DESC commited in https://cgit.freebsd.org/ports/commit/?id=7e9e1b6c9e710d094c9f0d5707a673dbe07cb2af
• I request permission to become a maintainer for this port

[vvd]

Can we go forward?

[tcberner]

In D45025#1028274, @vvd wrote:

• Use DESC commited in https://cgit.freebsd.org/ports/commit/?id=7e9e1b6c9e710d094c9f0d5707a673dbe07cb2af
• I request permission to become a maintainer for this port

Moin moin

I have no issue with moving this from kde@ to vvd@

mfg Tobias