test-includes: Add -ansi to the compile line to catch problems
ClosedPublic
Actions

Authored by imp on Dec 29 2023, 9:30 PM.

Details

Reviewers

dim
emaste
jrtc27

Commits

rG259e6fefc0ad: test-includes: Add -ansi to the compile line to catch problems

Summary

We support C89 files, but compile everything in the tree with C99 or
newer. By compiling these -ansi, that will force C89 which doesn't
understand inline. All our header files must use __inline instead of
inline when they define inline functions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Dec 29 2023, 9:30 PM

imp created this revision.

Harbormaster completed remote builds in B55153: Diff 131985.Dec 29 2023, 9:30 PM

imp edited the test plan for this revision. (Show Details)Dec 29 2023, 9:32 PM

imp added reviewers: dim, emaste, jrtc27.

I'm happy with this if it passes. One small comment on a comment though.

tools/build/test-includes/Makefile
25	is "niggles" likely to be widely understood?

This revision is now accepted and ready to land.Dec 29 2023, 9:36 PM

Does this suffice, or do we need to do all supported C standard variations?

Comprehensive testing would be nice, but checking for the specific cases we've encountered is probably sufficient.

reword comment to use more main-stream language.

This revision now requires review to proceed.Dec 29 2023, 10:56 PM

Harbormaster completed remote builds in B55156: Diff 131988.Dec 29 2023, 10:56 PM

imp marked an inline comment as done.Dec 29 2023, 10:58 PM

imp added inline comments.

tools/build/test-includes/Makefile
25	Well... maybe... but I reworded it to be less obscure.... but fussy details might be a better match, since niggles connotes annoying things more so than fussy details.