LinuxKPI: Add write_seqcount_invalidate() and seqprop_sequence()
ClosedPublic
Actions

Authored by wulf on Nov 28 2023, 9:11 PM.

Details

Reviewers

Commits

Summary

functions to linux/seqlock.h

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

wulf requested review of this revision.Nov 28 2023, 9:11 PM

This revision is now accepted and ready to land.Nov 29 2023, 6:14 AM

bz requested changes to this revision.Dec 8 2023, 5:40 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/seqlock.h
92	I would put a comment there; almost wants sys/seqc.h integration?
187	Do you want seqc_read_notmodify()?

This revision now requires changes to proceed.Dec 8 2023, 5:40 PM

READ_ONCE -> atomic_load_int

sys/compat/linuxkpi/common/include/linux/seqlock.h
92	I do not understand what type comment and integration you expect? Move this code to sys/seqc.h and make write_seqcount_invalidate a wrapper?
187	No. It's relaxed version of seqc_read_notmodify() I replaced READ_ONCE() with atomic_load() to make things clearer