Page MenuHomeFreeBSD

stand: Stop building in fat, ext2fs, gzip and bzip to BIOS /boot/loader
ClosedPublic

Authored by imp on Oct 31 2023, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 7 2024, 9:28 PM
Unknown Object (File)
Oct 5 2024, 5:49 PM
Unknown Object (File)
Oct 3 2024, 1:06 AM
Unknown Object (File)
Oct 2 2024, 10:16 PM
Unknown Object (File)
Oct 2 2024, 6:20 PM
Unknown Object (File)
Oct 1 2024, 10:08 PM
Unknown Object (File)
Oct 1 2024, 9:59 PM
Unknown Object (File)
Oct 1 2024, 2:23 PM

Details

Summary

This saves space to allow pxeboot to work again. Users desiring these
features can turn them on for their custom build. While these are useful
for some specialized applications, they aren't needed to boot the
typical system, and we're low on space.

text    data     bss      dec       hex   filename

Before: 465866 20740 31612 518218 0x7e84a loader_lua.bin
After: 441535 17484 31092 490111 0x77a7f loader_lua.bin

Savings: 28,107 bytes

Sponsored by: Netflix

Test Plan

This is a stop-gap, but a super-easy one to do.

I'm ruing the day we have to enforce a freeze on new features/compression/crypto in ZFS so things will still fit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 31 2023, 8:00 PM
This revision is now accepted and ready to land.Oct 31 2023, 8:14 PM
stand/i386/loader/Makefile
10–11

I think this is in somewhat wide use?

stand/i386/loader/Makefile
10–11

They will need to build custom. I could add MK_LOADER_BIOS_xxx maybe

jo_bruelltuete.com added inline comments.
stand/i386/loader/Makefile
10–11

I just got bitten in the butt by this with upgrading from 13.3 to 13.4.
Would have been good to mention this in UPDATING or release notes.

stand/i386/loader/Makefile
10–11

Yes. It would have been nice, but I didn't think of it in time for either. And I didn't appreciate that people would care until they started getting bitten by it. And after I saw who was affected, I knew I should have done more, but all I could do is fix it like this after the fact. I'm sorry that this cause you grief, and vastly underestimated its popularity.