Page MenuHomeFreeBSD

Makefile.inc1: move MOVED_LIBS under list-old-files
AbandonedPublic

Authored by dim on Oct 13 2023, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 8:21 PM
Unknown Object (File)
Oct 1 2024, 5:21 AM
Unknown Object (File)
Oct 1 2024, 1:30 AM
Unknown Object (File)
Sep 26 2024, 11:16 PM
Unknown Object (File)
Sep 26 2024, 6:19 PM
Unknown Object (File)
Sep 5 2024, 6:56 AM
Unknown Object (File)
Sep 2 2024, 7:17 PM
Unknown Object (File)
Aug 5 2024, 10:04 AM
Subscribers
None

Details

Summary

Moved dynamic libraries are never bumped, so old copies should never
stay around. Therefore, put any MOVED_LIBS from ObsoleteFiles.inc under
the list-old-files target so they may be deleted, even if users run
"make delete-old-files", but do not run "make delete-old-libs". (The
latter target is sometimes postponed, for example due to installed ports
still requiring the older libraries.)

In particular, this avoids keeping around an old /usr/lib/libc++.so.1
after a new version has been installed in /lib, which could lead to
"Undefined symbol" errors in certain circumstances.

PR: 272642
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53973
Build 50863: arc lint + arc unit

Event Timeline

dim requested review of this revision.Oct 13 2023, 6:19 PM
dim created this revision.
Makefile.inc1
3376

I think we want to leave this one here, at least for now: a user could run make delete-old-files, update their tree across this change, then run make delete-old-libs and not handle the file at all

Yeah you're right, let's go for D42197 instead.