Page MenuHomeFreeBSD
Differential D42061

net/qt5-network: Drop ca_root_nss dependency.
ClosedPublic
Actions

Authored by des on Oct 3 2023, 5:16 AM.
Tags
None
Referenced Files
F109640674: D42061.diff
Fri, Feb 7, 9:00 PM
Unknown Object (File)
Nov 25 2024, 2:01 AM
Unknown Object (File)
Nov 23 2024, 5:38 AM
Unknown Object (File)
Nov 7 2024, 7:14 AM
Unknown Object (File)
Nov 7 2024, 1:09 AM
Unknown Object (File)
Nov 5 2024, 2:43 PM
Unknown Object (File)
Oct 30 2024, 6:14 PM
Unknown Object (File)
Oct 20 2024, 6:12 PM
View All 53 Files
Subscribers
arrowd
jhale
mat

Details

Reviewers
jhale
Group Reviewers
kde
Commits
R11:676b3bd11efc: net/qt5-network: Drop ca_root_nss dependency.
Summary

MFH: 2023Q4

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53808
Build 50699: arc lint + arc unit

Event Timeline

des created this revision.Oct 3 2023, 5:16 AM
Herald added a subscriber: mat. · View Herald TranscriptOct 3 2023, 5:16 AM
des requested review of this revision.Oct 3 2023, 5:16 AM
Harbormaster completed remote builds in B53808: Diff 128144.Oct 3 2023, 5:16 AM
des changed the repository for this revision from rP FreeBSD ports repository to R11 FreeBSD ports repository.Oct 3 2023, 5:19 AM
arrowd added a subscriber: arrowd.Oct 3 2023, 6:02 AM

A little explanation for this?

des added a comment.Oct 5 2023, 8:10 PM

There's not much to explain, this hasn't been needed since certctl(8) was introduced in 12.2. Qt will do the right thing and use the system trust store, which in FreeBSD >= 12.2 is fully populated.

arrowd added a comment.Oct 6 2023, 6:04 AM

I'm not an expert in this stuff. So we certainly don't need an exp-run for this change?

des added a comment.Oct 6 2023, 8:31 AM

What difference would an exp-run make?

jhale added a subscriber: jhale.Oct 8 2023, 9:19 PM
jhale added a comment.Oct 8 2023, 9:23 PM

Looks good to me. Exp-run wouldn't make any sense for a runtime dependency. w/ kde@ hat on.

jhale accepted this revision.Oct 8 2023, 9:24 PM
This revision is now accepted and ready to land.Oct 8 2023, 9:24 PM
Closed by commit R11:676b3bd11efc: net/qt5-network: Drop ca_root_nss dependency. (authored by des). · Explain WhyOct 9 2023, 12:42 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:676b3bd11efc: net/qt5-network: Drop ca_root_nss dependency..

Revision Contents
Changeset List

PathSize
net/
qt5-network/
3 lines

Diff 128144

View Options

net/qt5-network/Makefile

Loading...