Page MenuHomeFreeBSD

linuxkpi: Fix uses of `pmap_change_attr()`
ClosedPublic

Authored by dumbbell on Oct 2 2023, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 2:45 AM
Unknown Object (File)
Thu, Feb 6, 2:14 PM
Unknown Object (File)
Mon, Jan 27, 9:18 AM
Unknown Object (File)
Thu, Jan 23, 11:57 PM
Unknown Object (File)
Tue, Jan 21, 11:45 AM
Unknown Object (File)
Jan 10 2025, 12:02 PM
Unknown Object (File)
Jan 10 2025, 11:19 AM
Unknown Object (File)
Jan 10 2025, 6:58 AM

Details

Summary

Why

This function takes an offset and a length as argument, not a physical address and a number of pages.

This misuse caused the set_memory_*() and arch_io_reserve_memtype_wc() functions to return EINVAL.

Another problem was the fact that they returned errors as a positive integer, whereas Linux uses negative integers.

How

Physical addresses and number of pages are converted to offset+length in the set_memory_*() functions.

arch_io_reserve_memtype_wc() now calls pmap_change_attr() directly instead of using set_memory_wc().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable