Page MenuHomeFreeBSD

linuxkpi: Fix uses of `pmap_change_attr()`
ClosedPublic

Authored by dumbbell on Oct 2 2023, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 9, 1:07 PM
Unknown Object (File)
Wed, Oct 9, 1:06 PM
Unknown Object (File)
Wed, Oct 9, 1:06 PM
Unknown Object (File)
Wed, Oct 9, 1:02 PM
Unknown Object (File)
Oct 4 2024, 7:15 PM
Unknown Object (File)
Oct 4 2024, 4:09 PM
Unknown Object (File)
Oct 3 2024, 9:39 AM
Unknown Object (File)
Oct 3 2024, 1:06 AM

Details

Summary

Why

This function takes an offset and a length as argument, not a physical address and a number of pages.

This misuse caused the set_memory_*() and arch_io_reserve_memtype_wc() functions to return EINVAL.

Another problem was the fact that they returned errors as a positive integer, whereas Linux uses negative integers.

How

Physical addresses and number of pages are converted to offset+length in the set_memory_*() functions.

arch_io_reserve_memtype_wc() now calls pmap_change_attr() directly instead of using set_memory_wc().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable