Differential D42006

dtc: Ensure it is built in C++17 mode
ClosedPublic
Actions

Authored by jlduran on Sep 28 2023, 8:10 AM.

Tags

None

Referenced Files

	F108662617: D42006.diff
	Mon, Jan 27, 3:59 AM

	Unknown Object (File)
	Sun, Jan 19, 1:54 PM

	Unknown Object (File)
	Dec 28 2024, 3:57 AM

	Unknown Object (File)
	Dec 3 2024, 3:35 AM

	Unknown Object (File)
	Oct 27 2024, 11:01 AM

	Unknown Object (File)
	Oct 21 2024, 4:55 AM

	Unknown Object (File)
	Sep 27 2024, 3:27 AM

	Unknown Object (File)
	Sep 23 2024, 4:13 PM

View All 27 Files

Subscribers

imp

jrtc27

Contributor Reviews (src)

Details

Reviewers

emaste
kevans
theraven

Commits

rGf147cf0ee2b2: dtc: Ensure it is built in C++17 mode

Summary

Explicitly specify the C++ standard to be used in the Makefile.
This prevents macOS cross-builds from using the default gnu++98 and fail.
This syncs dtc with upstream commit 39a58cfaab7d55c7975ebf905d859ba91a369fa0.

Fixes: 29a55fd09b0a3cc4c888f7a630fde41694699343

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Sep 28 2023, 8:10 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2023, 8:10 AM

jlduran requested review of this revision.Sep 28 2023, 8:10 AM

emaste accepted this revision.Sep 29 2023, 1:23 PM

emaste added a subscriber: jrtc27.

This revision is now accepted and ready to land.Sep 29 2023, 1:23 PM

emaste added a commit: rGf147cf0ee2b2: dtc: Ensure it is built in C++17 mode.Sep 29 2023, 1:27 PM

Closed by commit rGf147cf0ee2b2: dtc: Ensure it is built in C++17 mode (authored by jlduran, committed by emaste). · Explain WhySep 29 2023, 1:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

dtc/

Makefile

2 lines

Diff 127999

View Options

dtc: Ensure it is built in C++17 modeClosedPublicActions