Page MenuHomeFreeBSD

cat: report copy_file_range() errors with the read filename
AcceptedPublic

Authored by kevans on Sep 8 2023, 4:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 9:47 AM
Unknown Object (File)
Thu, Oct 17, 4:44 AM
Unknown Object (File)
Thu, Oct 17, 4:44 AM
Unknown Object (File)
Thu, Oct 17, 4:23 AM
Unknown Object (File)
Oct 4 2024, 9:57 PM
Unknown Object (File)
Oct 2 2024, 11:59 PM
Unknown Object (File)
Oct 2 2024, 11:14 AM
Unknown Object (File)
Sep 30 2024, 8:55 PM
Subscribers

Details

Reviewers
des
mm
allanjude
Summary

The error may be due to an error while writing, but it's more helpful to
report what we were trying to from rather than "stdout" for these
errors. Noticed because of what happens now when cat gets an EISDIR
for reading from a dirfd:

kevans@ifrit:~$ cat /etc
cat: stdout: Is a directory

which, after this change, becomes:

kevans@aarch64-dev:~$ cat /etc
cat: /etc: Is a directory

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53506
Build 50397: arc lint + arc unit