Differential D41758

unifdef: Handle redefined symbols correctly.
ClosedPublic
Actions

Authored by des on Sep 6 2023, 5:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 24, 4:22 PM

	Unknown Object (File)
	Tue, Sep 24, 10:04 AM

	Unknown Object (File)
	Tue, Sep 24, 10:03 AM

	Unknown Object (File)
	Tue, Sep 24, 10:03 AM

	Unknown Object (File)
	Tue, Sep 24, 10:03 AM

	Unknown Object (File)
	Tue, Sep 24, 9:55 AM

	Unknown Object (File)
	Tue, Sep 24, 4:29 AM

	Unknown Object (File)
	Mon, Sep 16, 7:55 PM

View All 36 Files

Subscribers

Details

Reviewers

cem
lwhsu
kevans

Group Reviewers

Commits

rG0171f9ccfed8: unifdef: Handle redefined symbols correctly.
rGd194776d7df1: unifdef: Vendorize.
rGaacbe7384221: unifdef: Handle redefined symbols correctly.

Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sep 6 2023, 5:44 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2023, 5:44 AM

des requested review of this revision.Sep 6 2023, 5:44 AM

Harbormaster completed remote builds in B53463: Diff 126947.Sep 6 2023, 5:44 AM

iana_apple.com added a subscriber: iana_apple.com.Sep 6 2023, 5:53 AM

kevans added a subscriber: kevans.Sep 6 2023, 4:51 PM

kevans added inline comments.

contrib/unifdef/unifdef.c
1560	This seems reasonable... I kind of wish the manpage defined solid expectations for what to do with -D/-U/-i (even if that expectation is just "last one for a name wins"). Do we want the below debugsym to still output "addsym" for symbols, or do we want "updatesym" or some such to reflect that it's a multiply-listed option?

kevans added inline comments.Sep 6 2023, 4:52 PM

contrib/unifdef/unifdef.c
1560	"what to do with" -> "what to do with multiple occurrences of"

Oh, but what's here looks fine otherwise... the manpage is a punt-able problem

This revision is now accepted and ready to land.Sep 6 2023, 5:04 PM

say "updsym" instead of "addsym" when redefining

This revision now requires review to proceed.Sep 6 2023, 5:08 PM

Harbormaster completed remote builds in B53472: Diff 126972.Sep 6 2023, 5:08 PM

des marked 2 inline comments as done.Sep 6 2023, 5:08 PM

kevans accepted this revision.Sep 6 2023, 5:10 PM

This revision is now accepted and ready to land.Sep 6 2023, 5:10 PM

Closed by commit rGaacbe7384221: unifdef: Handle redefined symbols correctly. (authored by des). · Explain WhySep 6 2023, 5:12 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGaacbe7384221: unifdef: Handle redefined symbols correctly..

des added a commit: rGd194776d7df1: unifdef: Vendorize..Sep 7 2023, 2:54 PM

des added a commit: rG0171f9ccfed8: unifdef: Handle redefined symbols correctly..Sep 7 2023, 8:29 PM

Revision Contents
Changeset List

Path

Size

contrib/

unifdef/

6 lines

usr.bin/

unifdef/

tests/

unifdef_test.sh

21 lines

Diff 126973

contrib/unifdef/unifdef.c

Loading...

usr.bin/unifdef/tests/unifdef_test.sh

Loading...