Page MenuHomeFreeBSD

clk_fixed: reduce and clarify messages due to missing clk-frequency
ClosedPublic

Authored by karels on Aug 25 2023, 4:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 10:51 AM
Unknown Object (File)
Tue, Apr 15, 7:54 PM
Unknown Object (File)
Tue, Apr 15, 6:43 PM
Unknown Object (File)
Tue, Apr 15, 6:35 PM
Unknown Object (File)
Tue, Apr 15, 4:43 PM
Unknown Object (File)
Mon, Apr 14, 1:16 AM
Unknown Object (File)
Sun, Apr 13, 11:48 AM
Unknown Object (File)
Mon, Apr 7, 12:02 AM
Subscribers

Details

Summary

The current dts for Raspberry 3B+ and 4B have 2 disabled fixed-clock
nodes which have no clock-frequency value. Such nodes are non-standard.
This results in about 150 messages during autoconfiguration:

clk_fixed2: <Fixed clock> disabled on ofwbus0
clk_fixed2: Cannot FDT parameters.
device_attach: clk_fixed2 attach returned 6

Defensively check for clock-frequency in the probe routine, and if
none, return an error with a more direct error message (1 line per
occurrence, 50 lines total):

clk_fixed2: clock-fixed has no clock-frequency

Based on a patch by manu.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable