Toolchain components were historically statically linked. They became normal dynamically linked executables in commit 6ab18ea64d19. There is no need to keep a special case build option for the toolchain; users who want statically linked toolchain (or any other) components can use the existing NO_SHARED knob. Relnotes: Yes Sponsored by: The FreeBSD Foundation
Details
- Reviewers
dim sjg - Commits
- rG77f6be448408: retire SHARED_TOOLCHAIN knob
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
share/mk/local.sys.dirdeps.mk | ||
---|---|---|
68 | Or, should this become NO_SHARED=yes? |
We could extend/use @cperciva's REQUIRED_OPTIONS functionality (b908f6c45e0202deb86fc9bde1b07212924c05fc) to facilitate the knob deprecation, but IMO it is unnecessary.
The time is indeed ripe for this setting to go, but the "toolchains can be a pain" line is maybe a little worrying? @sjg put it in, in rG0244ab1f26bcc, but that was a looooong time ago...
The "toolchains can be a pain" comment predated the addition of NO_SHARED_TOOLCHAIN there; the commit message says "(for now) non-shared toolchain when building for host". It doesn't explain what was actually broken but the "for now" suggests it wasn't intended to be permanent. I'd be fine with going ahead with this and revisiting host toolchain build if it proves necessary, but either way I'll give @sjg some time to review/comment before committing.
share/mk/local.sys.dirdeps.mk | ||
---|---|---|
68 | I think it can just go away, if I discover otherwise I can fix it ;-) |