dtrace: improve siftr probe

[tuexen]

Summary

Improve consistency of the field names with tcpsinfo_t:

• Use mss instead of max_seg_size.
• Use lport and rport instead of tcp_localport and tcp_foreignport.

Use t_flags instead of flags to improve consistency with t_flags2.

Add laddr and raddr, since the addresses were missing when compared to the output of siftr.

[cc]

sys/netinet/siftr.c

228–230

Looks we can safely remove these three and use your newly added ones to print (snprintf).

[tuexen]

Remove the ipver field of struct flowinfo, since it was never read.

[tuexen]

sys/netinet/siftr.c

228–230

It is save to remove ipver, since it was never read.
lport and rport are read when writing the flow summary at which point we don't have a struct pkt_node. So they are needed in struct flow_info.
So I guess we have to live with the duplication...