Have it call the platform-dependent version. For better layering, move
the reset logic inside the new function. This is mainly to facilitate an
upcoming change.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/libpmc/libpmc.c | ||
---|---|---|
1051 | Not related to this change, but I noticed that the count parameter that was added in 2018 is both undocumented and unnecessary - pmc_set(3)being the recommended way to set or change the counts associated with a PMC. |
lib/libpmc/libpmc.c | ||
---|---|---|
1051 | It is documented by the pmc_allocate(3) man page at least -- apparently I did this in 50f6c13997008. But to your point, I do not know why it was added. |