Page MenuHomeFreeBSD

net80211: add watchdog routines
Needs ReviewPublic

Authored by avos on Oct 31 2015, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 1:41 PM
Unknown Object (File)
Sun, Nov 17, 12:41 PM
Unknown Object (File)
Thu, Oct 31, 11:01 PM
Unknown Object (File)
Mon, Oct 21, 6:53 AM
Unknown Object (File)
Oct 18 2024, 11:31 PM
Unknown Object (File)
Oct 7 2024, 2:08 AM
Unknown Object (File)
Oct 6 2024, 11:47 PM
Unknown Object (File)
Oct 5 2024, 9:56 PM

Details

Reviewers
adrian
Summary

This implementation should replace driver-level watchdog implementations (and, as a result, reduce size of driver-specific code).

The watchdog can be enabled via
ic->ic_flags_ext |= IEEE80211_FEXT_WATCHDOG;
code line before calling ieee80211_ifattach();

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos retitled this revision from to net80211: add watchdog routines.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
  • Call ieee80211_tx_watchdog_refresh() before calling ic_transmit() / ic_raw_xmit(); that adds a possibility to call it from the callee error handler.
  • Update watchdog timer only when transmission occurs.
  • Add few more checks.

Fix race between ieee80211_tx_watchdog_stop() and ieee80211_tx_watchdog_refresh().

sys/net80211/ieee80211_freebsd.c
610–611

Hi,

I would like to ask few questions about this patch. As I see, tx_queued is incremented on transmission, but I don't see how it will be decremented in sunny day scenario. It's int16_t (max = 32768, then overflow)