Page MenuHomeFreeBSD

libarchive: Avoid a build failure with OpenSSL 3.0
AbandonedPublic

Authored by khorben_defora.org on Jun 1 2023, 6:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 11:10 AM
Unknown Object (File)
Feb 25 2025, 5:59 PM
Unknown Object (File)
Feb 21 2025, 8:41 PM
Unknown Object (File)
Jan 24 2025, 9:53 PM
Unknown Object (File)
Jan 18 2025, 8:39 AM
Unknown Object (File)
Jan 9 2025, 12:25 PM
Unknown Object (File)
Dec 7 2024, 2:19 PM
Unknown Object (File)
Nov 21 2024, 10:07 AM
Subscribers

Details

Reviewers
emaste
ngie
Summary

OPENSSL_API_COMPAT was used to specify the OpenSSL 1.1 API version for libarchive (as per https://reviews.freebsd.org/rG5a7500dab9b8480dacd5a9b70bad1541391342e4), preparing for the switch to OpenSSL 3.0. Unfortunately this broke the build with compilers checking for discarded qualifiers, since OpenSSL's OSSL_PARAM_construct_utf8_string() expects a char * but is really fine with string litterals according to EVP_MAC_fetch(3).

This change is a NFC while we're still using OpenSSL 1.1.1 but will avoid deprecation warnings upon the switch to OpenSSL 3.0.

A future update may migrate to use the OpenSSL 3.0 APIs.

PR: 271615
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped