genl: add new command to list genetlink(4)
ClosedPublic
Actions

Authored by bapt on May 30 2023, 10:08 AM.

Details

Reviewers

melifaro
kp

Commits

rGcb1fc924d2c0: genl: add new command to list genetlink(4)

Summary

This commands list genetlink protocols and its operations and
capabilities

$ genl
Name: nlctrl
ID: 0x10, Version: 00, header size: 2, max attributes: 10
supported operations:

ID: 0x3, Capabilities: 0xe (can modify; can get/dump;

has policy)
multicast groups:

ID: 0x30, Name: notify

Name: carp
ID: 0x11, Version: 00, header size: 2, max attributes: 2
supported operations:

ID: 0x1, Capabilities: 0xe (can modify; can get/dump;

has policy)

ID: 0x2, Capabilities: 0xb (requires admin permission;

can modify; has policy)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.May 30 2023, 10:08 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2023, 10:08 AM

bapt requested review of this revision.May 30 2023, 10:08 AM

Harbormaster completed remote builds in B51770: Diff 122601.May 30 2023, 10:09 AM

bapt added reviewers: melifaro, kp.May 30 2023, 10:09 AM

Wow, that's nice!
LGTM, though I'd suggest trying to add structured output from day one. I managed to convert ndp(8) ( D35677 ), so if you could consider looking into that option, that would be awesome!

This revision is now accepted and ready to land.May 30 2023, 10:25 AM

melifaro added inline comments.May 30 2023, 10:30 AM

usr.bin/Makefile
238	Also, I think our notation is that we have `MK_FEATURE` for binaries and `MK_FEATURE_SUPPORT` for the feature support inside binaries. Here we actually need `MK_NETLINK`. It was added previously but removed in D39678 with the idea that it can be easily re-added once need. Guess it's time to re-add :-)