Page MenuHomeFreeBSD

Refactor tcp_get_srtt()
ClosedPublic

Authored by jtl on May 27 2023, 3:06 PM.
Tags
None
Referenced Files
F97635027: D40304.diff
Mon, Sep 30, 12:19 PM
F97604038: D40304.diff
Mon, Sep 30, 7:47 AM
Unknown Object (File)
Sat, Sep 28, 9:30 AM
Unknown Object (File)
Fri, Sep 27, 12:28 AM
Unknown Object (File)
Wed, Sep 18, 8:27 AM
Unknown Object (File)
Sat, Sep 7, 7:38 PM
Unknown Object (File)
Jul 26 2024, 11:37 AM
Unknown Object (File)
Jul 10 2024, 2:22 PM

Details

Summary

After rGf5abdb03119a, it looks like there is an opportunity to refactor tcp_get_srtt() into its two component operations: unit conversion and shifting.

This should not cause any functional change.

Note for the future: I question whether it is a good idea for the long-term to manage the complexity of maintaining alternate unit storage in the TCB. If there is not already a plan for unifying the unit used for these values, I think we should consider making one.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jtl requested review of this revision.May 27 2023, 3:06 PM

There is the plan to move the base stack away from ticks and use usecs everywhere. But we wanted not to do this before stable/14 is branched.

This revision is now accepted and ready to land.May 27 2023, 7:01 PM
This revision was automatically updated to reflect the committed changes.