Page MenuHomeFreeBSD
Differential D39954

ntpd: Support IPv6-only hosts
ClosedPublic
Actions

Authored by freebsd_igalic.co on May 4 2023, 10:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 20, 3:40 PM
Unknown Object (File)
Wed, Sep 18, 10:00 AM
Unknown Object (File)
Wed, Sep 18, 3:55 AM
Unknown Object (File)
Tue, Sep 17, 7:44 PM
Unknown Object (File)
Tue, Sep 17, 2:40 PM
Unknown Object (File)
Mon, Sep 16, 1:16 PM
Unknown Object (File)
Mon, Sep 16, 10:15 AM
Unknown Object (File)
Sat, Sep 14, 11:09 PM
View All 93 Files
Subscribers
cy
emaste
imp
jlduran_gmail.com

Details

Reviewers
cy
emaste
Commits
rGd3ee609cf29e: ntpd: Support IPv6-only hosts
rG3f39a2a83945: ntpd: Support IPv6-only hosts
rGfff1551c0357: ntpd: Support IPv6-only hosts
Summary

0.pool.* returns only IPv4 addresses.
2.pool.* returns both, IPv6 and IPv4 addresses.

conservatively extend our IPv4 only pool configuration by adding a
second pool, which also returns IPv6 addresses.

PR: 270536
Reported by: Lapo Luchini <lapo@lapo.it>
Pull Request: https://github.com/freebsd/freebsd-src/pull/731

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freebsd_igalic.co created this revision.May 4 2023, 10:31 AM
Herald added subscribers: cy, imp. · View Herald TranscriptMay 4 2023, 10:31 AM
freebsd_igalic.co requested review of this revision.May 4 2023, 10:31 AM
Harbormaster completed remote builds in B51323: Diff 121492.May 4 2023, 10:31 AM
freebsd_igalic.co edited the summary of this revision. (Show Details)May 4 2023, 10:33 AM
freebsd_igalic.co updated this revision to Diff 121493.May 4 2023, 11:02 AM

preserve double space after '.'

Harbormaster completed remote builds in B51324: Diff 121493.May 4 2023, 11:02 AM
emaste added a subscriber: emaste.May 4 2023, 6:59 PM

See also https://community.ntppool.org/t/the-time-has-come-we-must-enable-ipv6-entirely/1968/2

emaste added a comment.May 4 2023, 7:03 PM

If we do not add IPv6 addresses to the names other than 2.pool.ntp.org, the world will circumvent us.

cy accepted this revision.May 4 2023, 8:16 PM

This has been something on my todo list. I've yet discuss this very patch with Harlan at nwtime.org. Let me reach out to him again.

This revision is now accepted and ready to land.May 4 2023, 8:16 PM
cy added a comment.May 4 2023, 8:20 PM

Email sent.

emaste accepted this revision.May 4 2023, 10:09 PM
cy added a comment.May 5 2023, 4:32 AM

ntp.org (nwtime.org) does not manage ntppool.org. They are separate entities.

Closed by commit rGfff1551c0357: ntpd: Support IPv6-only hosts (authored by Mina Galic <freebsd_igalic.co>, committed by cy). · Explain WhyMay 5 2023, 4:40 AM
This revision was automatically updated to reflect the committed changes.
cy added a commit: rGfff1551c0357: ntpd: Support IPv6-only hosts.
freebsd_igalic.co added a comment.May 5 2023, 5:43 AM

that commit mangled my meta-data:
author Mina Galic <freebsd_igalic.co>
Instead of
author Mina Galić <freebsd@igalic.co>

jlduran_gmail.com added a subscriber: jlduran_gmail.com.May 5 2023, 12:21 PM
jlduran_gmail.com added inline comments.
usr.sbin/ntp/ntpd/ntp.conf
40

s/resolves/resolve/

emaste added inline comments.May 5 2023, 12:30 PM
usr.sbin/ntp/ntpd/ntp.conf
40

and addresses

cy added a commit: rG3f39a2a83945: ntpd: Support IPv6-only hosts.May 8 2023, 5:34 PM
cy added a commit: rGd3ee609cf29e: ntpd: Support IPv6-only hosts.
brooks mentioned this in D35268: Make ntp work out of the box at IPv6-only sites.May 10 2023, 9:21 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
ntp/
ntpd/
17 lines

Diff 121554

View Options

usr.sbin/ntp/ntpd/ntp.conf

Loading...