Page MenuHomeFreeBSD

Remove unused fields in siftr_stats. Thus, update the man page as well.
ClosedPublic

Authored by cc on Apr 24 2023, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 7:20 AM
Unknown Object (File)
Thu, Oct 17, 6:31 PM
Unknown Object (File)
Oct 8 2024, 12:43 AM
Unknown Object (File)
Oct 2 2024, 12:02 AM
Unknown Object (File)
Sep 28 2024, 7:25 PM
Unknown Object (File)
Sep 28 2024, 7:21 PM
Unknown Object (File)
Sep 28 2024, 5:28 PM
Unknown Object (File)
Sep 7 2024, 5:33 PM

Details

Summary

Remove unused fields in siftr_stats. Thus, update the man page as well.

Test Plan

Tested in Emulab testbed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cc requested review of this revision.Apr 24 2023, 11:48 AM
share/man/man4/siftr.4
32

You need to bump the date.

sys/netinet/siftr.c
114–115

Don't you need to bump V_BACKBREAK, since you are changing the output format in a non-compatible way (removing two entries)?

share/man/man4/siftr.4
32

Will do.

sys/netinet/siftr.c
114–115

I thought the recent changes such as t_flags2, flowid, and flowtype made this requirement insignificant. Just want to double confirm that is this version bump really necessary?

sys/netinet/siftr.c
114–115

I don't know. But I would expect the siftr version number to reflect changes in the siftr code. Since you are removing two fields from the trailer, I would assume it applies. Changes of the TCP code would be reflected in the OS version, I would guess.

sys/netinet/siftr.c
114–115

OK. Will do. I guess every time some field changes will inflate the siftr version number.

Update date in man page, and inflate siftr version.

This revision is now accepted and ready to land.Apr 24 2023, 6:53 PM