Page MenuHomeFreeBSD

python.mk: remove setuptools from RUN_DEPENDS
AcceptedPublic

Authored by vishwin on Mar 29 2023, 3:17 AM.
Tags
None
Referenced Files
F102642530: D39303.diff
Fri, Nov 15, 6:00 AM
Unknown Object (File)
Wed, Nov 6, 3:30 PM
Unknown Object (File)
Tue, Nov 5, 1:14 PM
Unknown Object (File)
Fri, Oct 18, 9:30 AM
Unknown Object (File)
Oct 16 2024, 7:03 AM
Unknown Object (File)
Oct 15 2024, 7:25 AM
Unknown Object (File)
Oct 14 2024, 9:37 AM
Unknown Object (File)
Oct 12 2024, 5:00 AM

Details

Reviewers
crees
Group Reviewers
Python
portmgr
Summary

Historically this was needed as a RUN_DEPENDS due to consumers using the included pkg_resources, which has been deprecated for some time now in favour of the importlib suite. (pkg_resources consumers are strongly advised to migrate to importlib.)

Additionally, due to environment pollution, this cannot be specified as a RUN_DEPENDS anywhere; consumers of consumers that need this functionality (setuptools_scm comes to mind) are to specify this in BUILD_DEPENDS only. Otherwise certain dependency trees are wrong, which can prevent tests from being available amongst other things.

Test Plan

exp-run

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 58939
Build 55826: arc lint + arc unit

Event Timeline

  • CHANGES: add setuptools removal from RUN_DEPENDS

Are you waiting for portmgr's approval ?
This file is maintained by python@, so, all you need is an exp-run to make sure everything is fine.

In D39303#1064274, @mat wrote:

Are you waiting for portmgr's approval ?
This file is maintained by python@, so, all you need is an exp-run to make sure everything is fine.

No, Herald (phab) added it automatically. This has already been exp-ran by both portmgr and myself with no problems. I'm basically acting as Python here but leaving this open for a bit to collect feedback on the CHANGES wording.

No, Herald (phab) added it automatically. This has already been exp-ran by both portmgr and myself with no problems. I'm basically acting as Python here but leaving this open for a bit to collect feedback on the CHANGES wording.

Ok, great, thank you for this work.

Minor grammatical suggestion.

CHANGES
20 ↗(On Diff #143396)

"Upstream" is a collective noun and when members of a group are acting as a unit, the singular verb should be used.

All good from my point of view. A note for curiosity that @jhale 's correction is correct for FreeBSD-- US English treats organisations as singular, whereas in the UK we treat them as plural. I prefer the US version :)

Thanks for doing this work, it's brilliant that you're working towards getting Python 3.12 in the tree and Doing It Properly too.

Looks as though the wording is OK with everyone? Just going to mark this as approved by python@ as I reckon timeout should apply here.

This revision is now accepted and ready to land.Fri, Nov 1, 6:06 PM

In principle, but still need to make the minor wording tweak(s). Also, this is meant to be committed with (but still immediately before) the setuptools update.