Page MenuHomeFreeBSD

makefs: correct El Torito bood record
ClosedPublic

Authored by emaste on Mar 23 2023, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 1:22 AM
Unknown Object (File)
Thu, Nov 7, 10:50 PM
Unknown Object (File)
Thu, Nov 7, 10:29 PM
Unknown Object (File)
Thu, Nov 7, 8:51 PM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:43 AM
Unknown Object (File)
Oct 5 2024, 6:22 AM
Subscribers

Details

Summary

The boot catalog pointer is a DWord, but we previously populated it via cd9660_bothendian_dword which overwrote four unused bytes following it. See El Torito 1.0 (1995) Figure 7 for details.

PR: 203531
Reported by: Coverity Scan
Reported by: Thomas Schmitt <scdbackup@gmx.net>
CID: 977470
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

A link to the El Torito doc is available from https://wiki.osdev.org/El-Torito

This matches my reading of the spec; single LE DWORD.

This revision is now accepted and ready to land.Mar 23 2023, 9:33 PM
This revision was automatically updated to reflect the committed changes.