Differential D39075

route.8: Don't reference an external command in EXAMPLES
ClosedPublic
Actions

Authored by gbe on Mar 14 2023, 4:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 7, 6:23 AM

	Unknown Object (File)
	Thu, Oct 24, 2:55 AM

	Unknown Object (File)
	Wed, Oct 16, 7:55 PM

	Unknown Object (File)
	Oct 15 2024, 1:35 PM

	Unknown Object (File)
	Oct 14 2024, 1:22 PM

	Unknown Object (File)
	Oct 11 2024, 1:08 PM

	Unknown Object (File)
	Oct 7 2024, 5:14 PM

	Unknown Object (File)
	Oct 7 2024, 12:29 AM

View All 54 Files

Subscribers

Details

Reviewers

• karels
rgrimes
gbe

Group Reviewers

Commits

rG15d683c334f9: route.8: Don't reference an external command in EXAMPLES
rG61dad7633cd3: route.8: Don't reference an external command in EXAMPLES
rG21f268182838: route.8: Don't reference an external command in EXAMPLES

Summary

It is better to mention the externel command for showing
the routing table as using an explicit command.

PR: 231579
Suggested by: mkarels
MFC after: 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gbe created this revision.Mar 14 2023, 4:49 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 14 2023, 4:49 AM

gbe requested review of this revision.Mar 14 2023, 4:49 AM

Harbormaster completed remote builds in B50350: Diff 118788.Mar 14 2023, 4:49 AM

gbe accepted this revision.Mar 14 2023, 4:50 AM

gbe added reviewers: manpages, • karels, rgrimes.

This revision is now accepted and ready to land.Mar 14 2023, 4:50 AM

gbe edited the summary of this revision. (Show Details)Mar 14 2023, 4:56 AM

• karels added inline comments.Mar 14 2023, 6:44 AM

sbin/route/route.8
490–491	This line isn't really helpful, but doesn't hurt too much.

Address comments

This revision now requires review to proceed.Mar 14 2023, 9:06 AM

Harbormaster completed remote builds in B50352: Diff 118790.Mar 14 2023, 9:06 AM

gbe marked an inline comment as done.Mar 14 2023, 9:07 AM

LGTM

This revision is now accepted and ready to land.Mar 14 2023, 12:43 PM

Closed by commit rG21f268182838: route.8: Don't reference an external command in EXAMPLES (authored by gbe). · Explain WhyMar 14 2023, 1:57 PM

This revision was automatically updated to reflect the committed changes.

gbe added a commit: rG21f268182838: route.8: Don't reference an external command in EXAMPLES.

• karels added inline comments.Mar 14 2023, 1:58 PM

sbin/route/route.8
492	whoops, I just noticed that the -r was changed to 1. That is wrong.

gbe added inline comments.Mar 15 2023, 12:56 PM

sbin/route/route.8
492	I am not sure what you exactly here. .Xr is used for man page references so it would show 'with netstat(1)' Would you like to use 'with netstat -r' in that case?

• karels added inline comments.Mar 15 2023, 1:01 PM

sbin/route/route.8
492	Sorry, I misread it.

gbe added a commit: rG61dad7633cd3: route.8: Don't reference an external command in EXAMPLES.Mar 16 2023, 1:13 PM

gbe added a commit: rG15d683c334f9: route.8: Don't reference an external command in EXAMPLES.Mar 17 2023, 6:31 AM

Revision Contents
Changeset List

Path

Size

sbin/

route/

7 lines

Diff 118799

sbin/route/route.8

Loading...