netlink: do not memcpy 0 bytes from a NULL pointer
AbandonedPublic
Actions

Authored by emaste on Mar 6 2023, 4:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 27, 9:29 AM

	Unknown Object (File)
	Sun, Oct 27, 9:28 AM

	Unknown Object (File)
	Sun, Oct 27, 9:17 AM

	Unknown Object (File)
	Oct 4 2024, 4:41 PM

	Unknown Object (File)
	Oct 3 2024, 8:16 AM

	Unknown Object (File)
	Sep 28 2024, 3:44 AM

	Unknown Object (File)
	Sep 27 2024, 5:40 PM

	Unknown Object (File)
	Sep 26 2024, 8:25 PM

View All 41 Files

Subscribers

glebius

melifaro

Details

Reviewers

melifaro

Commits

rGd9f07162932b: netlink: do not memcpy 0 bytes from a NULL pointer
rG305aaa93e0c8: netlink: do not memcpy 0 bytes from a NULL pointer

Summary

Although it works in practice it is UB, and might break after a future
compiler update.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Mar 6 2023, 4:34 PM

Herald added a reviewer: melifaro. · View Herald TranscriptMar 6 2023, 4:34 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

emaste requested review of this revision.Mar 6 2023, 4:34 PM

emaste added inline comments.

sys/netlink/route/iface.c
464	free(NULL) is fine of course, but I think including it in the if body is more clear

Just missed 055776c84a41bb88c6ccd67615ea172864f6804c :)

Although that said I think we ought to include either D38927 or 055776c84a41bb88c6ccd67615ea172864f6804c in 13.2.

emaste added a commit: rG305aaa93e0c8: netlink: do not memcpy 0 bytes from a NULL pointer.Mar 6 2023, 6:12 PM

emaste added a commit: rGd9f07162932b: netlink: do not memcpy 0 bytes from a NULL pointer.Mar 6 2023, 7:38 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

route/

iface.c

7 lines

Diff 118402

View Options

netlink: do not memcpy 0 bytes from a NULL pointerAbandonedPublicActions