Page MenuHomeFreeBSD

wpa: Address upstream regression committed in ec080394e218
AbandonedPublic

Authored by cy on Feb 27 2023, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 20, 4:43 PM
Unknown Object (File)
Fri, Sep 20, 1:13 PM
Unknown Object (File)
Thu, Sep 19, 12:43 PM
Unknown Object (File)
Wed, Sep 18, 10:40 PM
Unknown Object (File)
Wed, Sep 18, 9:54 PM
Unknown Object (File)
Sun, Sep 15, 4:13 AM
Unknown Object (File)
Sun, Sep 15, 4:13 AM
Unknown Object (File)
Sun, Sep 1, 12:03 PM

Details

Reviewers
bz
adrian
lwhsu
Summary

Upstream commit d807e289db96 no long set IFF_UP flag as it is considered
administrative only in OpenBSD and NetBSD. However, FreeBSD uses this
flag. Reinstate setting this flag based on interface status.

This commit also reverts 5fcdc19a8111 (and the subsequent 116679b39cb9
sleep removal) as they are no longer needed.

The upstream commit is based only on OpenBSD testing was assumed to work on NetBSD and FreeBSD too.

This patch is something we can start discussing with our upstream about. Even if they reject this change it allows us to build upon future revisions without significant merge conflicts.

Test Plan

All local tests have passed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped