Page MenuHomeFreeBSD
Differential D38801

dtrace_kinst(4): mention dtrace -l -P kinst, give a more complete example
ClosedPublic
Actions

Authored by christos on Feb 26 2023, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 9:55 AM
Unknown Object (File)
Sat, Nov 9, 9:46 PM
Unknown Object (File)
Sat, Nov 2, 6:40 AM
Unknown Object (File)
Sat, Nov 2, 6:40 AM
Unknown Object (File)
Sat, Nov 2, 6:40 AM
Unknown Object (File)
Sat, Nov 2, 6:40 AM
Unknown Object (File)
Sat, Nov 2, 6:40 AM
Unknown Object (File)
Sat, Nov 2, 6:15 AM
View All 66 Files
Subscribers
imp

Details

Reviewers
markj
gnn
Commits
rG2d71406a6ff3: dtrace_kinst.4: mention dtrace -l -P kinst, give a more complete example

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Feb 26 2023, 7:50 PM
Herald added a reviewer: gnn. · View Herald TranscriptFeb 26 2023, 7:50 PM
Herald added a subscriber: imp. · View Herald Transcript
christos requested review of this revision.Feb 26 2023, 7:50 PM
christos retitled this revision from dtrace_kinst(4): improve man page to dtrace_kinst(4): mention dtrace -l -P kinst, give a more complete example.Feb 26 2023, 7:59 PM
markj accepted this revision.Feb 27 2023, 1:47 PM

This looks ok to me modulo the nit. We can fix warnings in a separate patch - let me know if you'd like to handle this.

share/man/man4/dtrace_kinst.4
51–56

New sentences must start on new lines. mandoc -Tlint dtrace_kinst.4 will give warnings about things like this. Apparently I didn't run it before committing the initial revision of the man page though. :(

This revision is now accepted and ready to land.Feb 27 2023, 1:47 PM
christos updated this revision to Diff 118000.Feb 27 2023, 1:55 PM
christos marked an inline comment as done.

Fix all mandoc -Tlint warnings.

This revision now requires review to proceed.Feb 27 2023, 1:55 PM
markj added inline comments.Feb 27 2023, 2:11 PM
share/man/man4/dtrace_kinst.4
41

Maybe say "kgdb from the gdb package" instead.

christos updated this revision to Diff 118002.Feb 27 2023, 2:12 PM
christos marked an inline comment as done.
christos edited the summary of this revision. (Show Details)Feb 27 2023, 2:40 PM
christos edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2023, 3:04 PM
Closed by commit rG2d71406a6ff3: dtrace_kinst.4: mention dtrace -l -P kinst, give a more complete example (authored by christos, committed by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2d71406a6ff3: dtrace_kinst.4: mention dtrace -l -P kinst, give a more complete example.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
32 lines

Diff 118005

View Options

share/man/man4/dtrace_kinst.4

Loading...