Page MenuHomeFreeBSD

linux(4): Fixup the interface name translation in netlink
ClosedPublic

Authored by dchagin on Feb 21 2023, 10:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 7 2024, 12:42 AM
Unknown Object (File)
Sep 20 2024, 1:13 PM
Unknown Object (File)
Sep 20 2024, 7:46 AM
Unknown Object (File)
Sep 17 2024, 3:27 AM
Unknown Object (File)
Sep 15 2024, 1:30 AM
Unknown Object (File)
Sep 10 2024, 4:14 AM
Unknown Object (File)
Sep 4 2024, 7:15 PM
Unknown Object (File)
Sep 3 2024, 10:03 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/compat/linux/linux_netlink.c
283

You need to check the message type as well, as this value is only valud for RTM_<NEW|DEL|GET>LINK.

Also - for readability I’d consider moving attribute rewriting to a separate function. This will help keep copy-all_nla function readable when more translations are added

LGTM

sys/compat/linux/linux_netlink.c
241

Nit: worth describing the return codes here.

252

I'd explicitly cast it to int, or make it a branch, to help reader understand the return codes.

283–287
This revision is now accepted and ready to land.Feb 22 2023, 2:52 PM
This revision now requires review to proceed.Feb 22 2023, 6:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2023, 8:01 AM
This revision was automatically updated to reflect the committed changes.