Page MenuHomeFreeBSD

aio: Fix more synchronization issues in aio_biowakeup.
ClosedPublic

Authored by jhb on Feb 15 2023, 7:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 4:24 PM
Unknown Object (File)
Thu, Sep 26, 8:11 PM
Unknown Object (File)
Sat, Sep 21, 6:52 PM
Unknown Object (File)
Sun, Sep 15, 8:45 PM
Unknown Object (File)
Sun, Sep 15, 12:45 PM
Unknown Object (File)
Sun, Sep 1, 5:21 AM
Unknown Object (File)
Aug 18 2024, 4:18 PM
Unknown Object (File)
Aug 16 2024, 1:04 AM
Subscribers

Details

Summary
  • Use atomic_store to set job->error. atomic_set does an or operation, not assignment.
  • Use refcount_* to manage job->nbio.

    This ensures proper memory barriers are present so that the last bio won't see a possibly stale value of job->error.
  • Don't re-read job->error after reading it via atomic_load.

Reported by: markj (1)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 15 2023, 7:02 PM

hrmpf

so turns out atomic_set *is* like atomic_store on linux....

mumbling ensues

that is just a side note though

another one is that the volatile u_int stuff for refcounts needs to die, but again not a blocker

This revision is now accepted and ready to land.Feb 15 2023, 7:06 PM