Page MenuHomeFreeBSD
Differential D38443

ssh: fix SIZEOF_TIME_T #define on i386
ClosedPublic
Actions

Authored by emaste on Feb 8 2023, 6:34 PM.
Tags
None
Referenced Files
F98117567: D38443.id.diff
Wed, Oct 2, 9:56 AM
Unknown Object (File)
Thu, Sep 26, 12:19 AM
Unknown Object (File)
Fri, Sep 20, 3:55 AM
Unknown Object (File)
Tue, Sep 17, 1:33 PM
Unknown Object (File)
Tue, Sep 17, 2:40 AM
Unknown Object (File)
Sat, Sep 14, 7:05 PM
Unknown Object (File)
Sat, Sep 7, 6:38 PM
Unknown Object (File)
Sat, Sep 7, 1:56 AM
View All 32 Files
Subscribers
None

Details

Reviewers
imp
kevans
des
bdrewery
Commits
rG26b9c45c8f65: ssh: fix SIZEOF_TIME_T #define on i386
rG59ab4b95129d: ssh: fix SIZEOF_TIME_T #define on i386
rGd795444930d1: ssh: fix SIZEOF_TIME_T #define on i386
rG1aa9a35f6361: ssh: fix SIZEOF_TIME_T #define on i386
Summary
Reported by:    imp
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Feb 8 2023, 6:34 PM
emaste created this revision.
emaste added a comment.Feb 8 2023, 6:36 PM

Will look at a better (more robust) way to do this later on but this should be a sufficient bandaid

imp accepted this revision.Feb 8 2023, 11:30 PM

This matches all supported FreeBSD architectures, going back several major releases. FreeBSD 7 or 8 changes armv7 to 64-bit time_t and FreeBSD 9? did 32-bit powerpc. Only i386 remained

This revision is now accepted and ready to land.Feb 8 2023, 11:30 PM
Closed by commit rG1aa9a35f6361: ssh: fix SIZEOF_TIME_T #define on i386 (authored by emaste). · Explain WhyFeb 8 2023, 11:34 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG1aa9a35f6361: ssh: fix SIZEOF_TIME_T #define on i386.
emaste added a commit: rG59ab4b95129d: ssh: fix SIZEOF_TIME_T #define on i386.Feb 13 2023, 1:21 AM
emaste added a commit: rGd795444930d1: ssh: fix SIZEOF_TIME_T #define on i386.
emaste added a commit: rG26b9c45c8f65: ssh: fix SIZEOF_TIME_T #define on i386.Feb 14 2023, 10:34 PM

Revision Contents
Changeset List

PathSize
crypto/
openssh/
4 lines

Diff 116824

View Options

crypto/openssh/config.h

Loading...