Page MenuHomeFreeBSD

fuz onboarding: steps 1--4 of § 7.1 committers guide
ClosedPublic

Authored by fuz on Feb 7 2023, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 5 2024, 11:05 AM
Unknown Object (File)
Sep 27 2024, 2:06 PM
Unknown Object (File)
Sep 21 2024, 12:18 PM
Unknown Object (File)
Sep 18 2024, 8:10 PM
Unknown Object (File)
Sep 5 2024, 2:08 AM
Unknown Object (File)
Sep 3 2024, 3:29 AM
Unknown Object (File)
Aug 18 2024, 1:05 PM
Unknown Object (File)
Aug 18 2024, 1:05 PM
Subscribers
None

Details

Summary
  1. shared/authors.adoc: add fuz
  2. shared/contrib-commiters.adoc: add fuz
  3. news: new committer (ports): Robert Clausecker (fuz)
  4. pgpkeys: add key for fuz

Step 5 is in src and will be posted as a separate DR.

Mentors: eduardo, flo

Test Plan

n/a

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 49598
Build 46488: arc lint + arc unit

Event Timeline

fuz requested review of this revision.Feb 7 2023, 1:38 PM
fuz created this revision.

@fuz_fuz.su

All looks good

website/data/en/news/news.toml
3

date is correct

This revision is now accepted and ready to land.Feb 7 2023, 2:21 PM

Don't forget to include:

Approved by: eduardo (mentor)

Cheers

(...)

A single commit is nice since Summary (that will be included as commit msg) describe all four steps.

I'm having some trouble pushing the changes.

FATAL -- ACCESS DENIED
Repo            doc                                                         
User            fuz                                                         
Stage           Before git was called                                       
Operation       Repo write                                                  

FATAL: W any doc fuz DENIED by fallthru
(or you mis-spelled the reponame)
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

This happens both with each change individually and all changes at once. I'll go check on IRC as to what seems to be happening.

Did you included in commit msg:

Differential Revision: https://reviews.freebsd.org/D###

?

I used a commit message like:

pgpkeys: add key for fuz

Onboard new ports committer Robert Clausecker (fuz)
in accordance with step 4 of sec. 7.1 committer's guide

Approved by:    eduardo (mentor)
See also:       D38417 (step 5)
Differential Revision: https://reviews.freebsd.org/D38416

what git remote -vshows?

e.g.
origin ssh://git@gitrepo.freebsd.org/doc.git (fetch)
--> origin ssh://git@gitrepo.freebsd.org/doc.git (push) <--

Just to exclude that you not fetched a read-only repo

I believe one of you two will have to commit to ports/access, enabling my commit bit, as per the new account guidelines: https://www.freebsd.org/internal/new-account/

Ok, I see it.

a - accounts@ Creates New Account - DONE
b - Mentor Activates New Committer’s Commit Bit
c - Additional Services (The mentor should add the new committer to the Developers group on the wiki and to the committer project on Phabricator.)

I've missed b) and c) steps.

I will wait for Florian to setup this steps right.

In D38416#874020, @fuz_fuz.su wrote:

I believe one of you two will have to commit to ports/access, enabling my commit bit, as per the new account guidelines: https://www.freebsd.org/internal/new-account/

Yes that's it. I hadn't thought about this either yet. We'll get this sorted shortly. I'll let Nuno do the commit.