Page MenuHomeFreeBSD

bhyve: Fix a buffer overread in the PCI hda device model.
ClosedPublic

Authored by jhb on Jan 19 2023, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 6, 12:16 PM
Unknown Object (File)
Mon, Jan 27, 3:57 AM
Unknown Object (File)
Thu, Jan 23, 5:06 PM
Unknown Object (File)
Jan 19 2025, 2:09 AM
Unknown Object (File)
Jan 18 2025, 12:04 PM
Unknown Object (File)
Jan 3 2025, 2:35 PM
Unknown Object (File)
Nov 16 2024, 11:38 AM
Unknown Object (File)
Nov 16 2024, 10:04 AM
Subscribers

Details

Summary

The sc->codecs array contains HDA_CODEC_MAX (15) entries. The
guest-supplied cad field in the verb provided to hda_send_command is a
4-bit field that was used as an index into sc->codecs without any
bounds checking. The highest value (15) would overflow the array.

Other uses of sc->codecs in the device model used sc->codecs_no to
determine which array indices have been initialized, so use a similar
check to reject requests for uninitialized or invalid cad indices in
hda_send_command.

PR: 264582
Reported by: Robert Morris <rtm@lcs.mit.edu>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable