net-p2p/bitmark updated because of btcd dependency updates and fixes
Details
- Reviewers
dmgk - Group Reviewers
Contributor Reviewers (ports) - Commits
- R11:e2732b2416ec: net-p2p/bitmark: update to 0.15.0
poudriere testport -i -j 13_1-amd64 net-p2p/bitmark
poudriere bulk -j 13_1-amd64 net-p2p/bitmark net-p2p/bitmark-daemon net-p2p/bitmark-cli
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
net-p2p/bitmark/Makefile | ||
---|---|---|
9 | Why did you remove this? |
net-p2p/bitmark/Makefile | ||
---|---|---|
9 | not checking my local repo for all the changes inFreeBSD ports :( Let me fix it |
net-p2p/bitmark/Makefile | ||
---|---|---|
24 | I'm not a Go expert, but why these packages need manual symlinking? |
some of these symlink commands come from the modules2tuple port used to determine the dependencies from the last go build command. However I found that it does not handle the /Vn version specific items where V0, V1 and V2 were all referenced, these add added by trial and error un til the port built successfully and would run correctly for my testing.
I'd suggest dropping GH_TUPLE and switching to GO_MODULE instead, something like https://gist.github.com/dmgk/3cd7a4f1c8ef45a7e1cd9f57cf4a466c
Also the "go" directive in go.mod needs to be bumped to at least 1.17 (or golang.org/x/sys downgraded to the version that still supports go1.16), otherwise I'm getting build errors:
# golang.org/x/sys/unix vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod) vendor/golang.org/x/sys/unix/syscall_unix.go:118:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
@dmgk thanks for the GO_MODULE suggestion, I had problems with dependent bitmark-* ports.
The only way I found for the present was to override the distinfo in each of their Makefiles.
Is there a better way perhaps?
What problem would it solve? In GO_MODULE mode, DIST_SUBDIR serves as a local GOPATH for each port, with nested GOMODCACHE. What would be the reason to move it elsewhere?