dwatch: install hard links with same mode as target
ClosedPublic
Actions

Authored by emaste on Nov 23 2022, 3:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 9:07 AM

	Unknown Object (File)
	Mon, Oct 28, 9:07 AM

	Unknown Object (File)
	Mon, Oct 28, 9:07 AM

	Unknown Object (File)
	Mon, Oct 28, 8:45 AM

	Unknown Object (File)
	Sep 21 2024, 11:44 PM

	Unknown Object (File)
	Sep 18 2024, 5:03 AM

	Unknown Object (File)
	Aug 24 2024, 9:45 PM

	Unknown Object (File)
	Aug 18 2024, 12:34 AM

View All 50 Files

Subscribers

imp

Details

Reviewers

dteske
bapt

Group Reviewers

pkgbase

Commits

rG2dd014ca0c74: dwatch: install hard links with same mode as target
rG7543a9c0280a: dwatch: install hard links with same mode as target

Summary

Previoulsy when using NO_ROOT we recorded METALOG entries for dwatch hard links with different file modes than their link targets, which is not permitted.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

As an aside I'm curious why dwatch is in cddl/

cddl/usr.sbin/dwatch/libexec/Makefile
25	Taken as the default from bsd.files.mk ${group}MODE?= ${SHAREMODE}

bapt accepted this revision.Nov 23 2022, 6:56 PM

This revision is now accepted and ready to land.Nov 23 2022, 6:56 PM

Closed by commit rG7543a9c0280a: dwatch: install hard links with same mode as target (authored by emaste). · Explain WhyNov 23 2022, 8:15 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG7543a9c0280a: dwatch: install hard links with same mode as target.

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2022, 8:15 PM

emaste added a commit: rG2dd014ca0c74: dwatch: install hard links with same mode as target.Mar 23 2023, 3:10 PM

Revision Contents
Changeset List

Path

Size

cddl/

usr.sbin/

dwatch/

libexec/

Makefile

1 line

Diff 113454

View Options

cddl/usr.sbin/dwatch/libexec/Makefile

dwatch: install hard links with same mode as targetClosedPublicActions